-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests script for board #28
tests script for board #28
Conversation
e7869a0
to
d41ba4a
Compare
Signed-off-by: Thing-han, Lim <[email protected]>
d41ba4a
to
a3d6821
Compare
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
a3d6821
to
4a530dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thank you!
I guess we want to make this the preferred way to perform tests and benchmarks. Can you please adjust the main README accordingly?
$ tests speed -t 100 -v
Traceback (most recent call last):
File "/tmp/mlkem-c-embedded/scripts/tests", line 290, in <module>
cli()
File "/nix/store/r725a3hx83v9k6222xc6kamf8rmzzlxs-python3.11-click-8.1.7/lib/python3.11/site-packages/click/core.py", line 1157, in __call__
return self.main(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/nix/store/r725a3hx83v9k6222xc6kamf8rmzzlxs-python3.11-click-8.1.7/lib/python3.11/site-packages/click/core.py", line 1078, in main
rv = self.invoke(ctx)
^^^^^^^^^^^^^^^^
File "/nix/store/r725a3hx83v9k6222xc6kamf8rmzzlxs-python3.11-click-8.1.7/lib/python3.11/site-packages/click/core.py", line 1688, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/nix/store/r725a3hx83v9k6222xc6kamf8rmzzlxs-python3.11-click-8.1.7/lib/python3.11/site-packages/click/core.py", line 1434, in invoke
return ctx.invoke(self.callback, **ctx.params)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/nix/store/r725a3hx83v9k6222xc6kamf8rmzzlxs-python3.11-click-8.1.7/lib/python3.11/site-packages/click/core.py", line 783, in invoke
return __callback(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/mlkem-c-embedded/scripts/tests", line 214, in speed
base_test(
File "/tmp/mlkem-c-embedded/scripts/tests", line 126, in base_test
check(file, expect, actual)
File "/tmp/mlkem-c-embedded/scripts/tests", line 107, in check
sys.exit(1)
^^^
NameError: name 'sys' is not defined
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
8e341fd
to
68fa39e
Compare
Signed-off-by: Thing-han, Lim <[email protected]>
Updated the README, but not sure if it's clear enough... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now. Thanks @potsrevennil!
Mainly added a python script for running tests on board. Merged the original tests script into it as well.
Currently it's slow to run the nistkat test on board, due to the bottleneck of IO. Checking the checksum on board would be better.