Change display for scores not awared pp #10918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanaya
requested changes
Jan 30, 2024
app/Models/Score/Model.php
Outdated
| @@ -174,6 +174,7 @@ public function getNewScoreAttribute(string $key) | |||
| 'legacy_total_score' => $this->score, | |||
| 'max_combo' => $this->maxcombo, | |||
| 'passed' => $this->pass, | |||
| 'ranked' => !$this->hidden, | |||
There was a problem hiding this comment.
this should be true for best model and false otherwise
(or maybe ignore the value if not solo score where it's being used)
|
Maybe the pp value render logic should just be split between legacy and solo score. |
nanaya
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10911
using🤔hiddenas the flag for legacy scores, not sure if there's a better mapping for it?