Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit recent scores to 48h #10913

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Limit recent scores to 48h #10913

merged 3 commits into from
Jan 30, 2024

Conversation

nanaya
Copy link
Collaborator

@nanaya nanaya commented Jan 30, 2024

This will roll through all the user's scores but apparently it's already doing something like it anyway due to the user index in prod has a lot more columns in it (instead of just user_id and ruleset_id). So maybe it'll be fine? 🤷‍♀️

One of the worst cases is going through something like 200k rows.

Resolves #10912.

This will roll through all the user's scores but apparently it's already
doing something like it anyway due to the user index in prod has a lot
more columns in it (instead of just user_id and ruleset_id)
Copy link
Collaborator

@notbakaneko notbakaneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the count returned needs to be updated too? 🤔

@notbakaneko notbakaneko enabled auto-merge January 30, 2024 11:43
@notbakaneko notbakaneko merged commit aafed6b into ppy:master Jan 30, 2024
3 checks passed
@nanaya nanaya deleted the score-recent branch July 26, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Recent plays" section on website shows scores older than 24h
2 participants