Fix nomination button disabled state with unresolved issues and discussion post editing #10907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notbakaneko
force-pushed
the
fix-nominated-button-unresolved-issue-count
branch
from
4161ee5 to
05f4fd1
Compare
notbakaneko
changed the title
because it's about the state change not if it's currently resolved.
nanaya
requested changes
Jan 30, 2024
| @@ -257,10 +257,10 @@ export default class DiscussionsState { | |||
| return this.nonDeletedDiscussions | |||
| .reduce((sum, discussion) => { | |||
| if (discussion.can_be_resolved && !discussion.resolved) { | |||
| if (discussion.beatmap_id == null) return sum++; | |||
| if (discussion.beatmap_id == null) return ++sum; | |||
There was a problem hiding this comment.
might as well just sum + 1 instead of dealing with subtlety of ++ operator. And it's not like the variable itself needs to be updated.
nanaya
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be incrementing the count before returning ( ﾟ ヮﾟ)a
Also fix the resolved check for editing posts
fixes #10906
The nomination will still fail if there are unresolved issues