Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add client check on registration and allow enabling both registration modes #10905

Merged
merged 6 commits into from
Jan 30, 2024
Merged

Add client check on registration and allow enabling both registration modes #10905

merged 6 commits into from
Jan 30, 2024

Conversation

nanaya
Copy link
Collaborator

@nanaya nanaya commented Jan 29, 2024 •
edited by peppy
Loading

The option is split into two:

# equivalent to previous default REGISTRATION_MODE=client
# REGISTRATION_MODE_CLIENT=true
# REGISTRATION_MODE_WEB=false

This assumes at least one mode is enabled otherwise the error messages will point to each other 🤷‍♀️

depends on:

notbakaneko
notbakaneko previously approved these changes Jan 30, 2024
View reviewed changes
@peppy peppy dismissed notbakaneko’s stale review January 30, 2024 05:01

The merge-base changed after approval.

peppy
peppy previously approved these changes Jan 30, 2024
View reviewed changes
@nanaya nanaya dismissed peppy’s stale review January 30, 2024 05:01

The merge-base changed after approval.

@peppy peppy merged commit ff73b05 into ppy:master Jan 30, 2024
3 checks passed
@nanaya nanaya deleted the client-check-reg branch July 26, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notbakaneko notbakaneko notbakaneko left review comments

@peppy peppy peppy left review comments

Assignees
No one assigned
Labels
area:user-profile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nanaya @peppy @notbakaneko