Merge pull request #10854 from nanaya/show-legacy-value

More useful return type for user score legacy preference
ppy · Jan 15, 2024 · e298042 · e298042
2 parents 22e0ba2 + 07ecf8a
commit e298042
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/app/Libraries/Search/ScoreSearchParams.php b/app/Libraries/Search/ScoreSearchParams.php
@@ -54,9 +54,14 @@ public static function fromArray(array $rawParams): static
         return $params;
     }
 
-    public static function showLegacyForUser(?User $user): bool
+    /**
+     * This returns value for isLegacy based on user preference
+     */
+    public static function showLegacyForUser(?User $user): null | true
     {
-        return $user?->userProfileCustomization?->legacy_score_only ?? UserProfileCustomization::DEFAULT_LEGACY_ONLY_ATTRIBUTE;
+        return $user?->userProfileCustomization?->legacy_score_only ?? UserProfileCustomization::DEFAULT_LEGACY_ONLY_ATTRIBUTE
+            ? true
+            : null;
     }
 
     public function getCountryCode(): string