Merge pull request #10857 from notbakaneko/feature/fix-initial-stick-…

…to-height Fix new discussion pinned position
ppy · Jan 19, 2024 · 0a0e215 · 0a0e215
2 parents 01720be + 8c2c2bb
commit 0a0e215
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/resources/js/beatmap-discussions/new-discussion.tsx b/resources/js/beatmap-discussions/new-discussion.tsx
@@ -137,10 +137,13 @@ export class NewDiscussion extends React.Component<Props> {
   }
 
   componentDidMount() {
-    this.updateStickToHeight();
     // watching for height changes on the stickTo element to handle horizontal scrollbars when they appear.
     $(window).on('resize', this.updateStickToHeight);
-    this.disposers.add(core.reactTurbolinks.runAfterPageLoad(action(() => this.mounted = true)));
+    this.disposers.add(core.reactTurbolinks.runAfterPageLoad(action(() => {
+      this.mounted = true;
+      this.updateStickToHeight();
+    })));
+
     if (this.props.autoFocus) {
       this.disposers.add(core.reactTurbolinks.runAfterPageLoad(() => this.inputBox.current?.focus()));
     }

diff --git a/resources/js/beatmap-discussions/new-review.tsx b/resources/js/beatmap-discussions/new-review.tsx
@@ -56,10 +56,12 @@ export default class NewReview extends React.Component<Props> {
   }
 
   componentDidMount(): void {
-    this.updateStickToHeight();
     // watching for height changes on the stickTo element to handle horizontal scrollbars when they appear.
     $(window).on('resize', this.updateStickToHeight);
-    this.disposers.add(core.reactTurbolinks.runAfterPageLoad(action(() => this.mounted = true)));
+    this.disposers.add(core.reactTurbolinks.runAfterPageLoad(action(() => {
+      this.mounted = true;
+      this.updateStickToHeight();
+    })));
   }
 
   componentWillUnmount(): void {