Don't force fs and vs shader file extension if shader load argument string already includes file extension #6514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tring already includes file extension
Co-authored-by: Dean Herbert <[email protected]>
peppy
approved these changes
Jan 29, 2025
|
https://github.com/ppy/osu-framework/actions/runs/13024083461/job/36330312104?pr=6514#step:8:33 It doesn't seem to be related to my changes, as far as I've looked into the stack trace there? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow shader files to be loaded, regardless of filename extension, as long as it's specified when using dependency injection. Otherwise, default to vs and fs for vertex and fragment shader respectively. ("sh_" prefix is still required)
The exception message is updated as well.
This might be a small change that might not matter to a lot of people since they can just follow as instructed and use the hardcoded filename extension, but it doesn't feel right to force people to accept on someone else's preference on something subjective IMO