Skip to content

Commit

Permalink
Fix some flake8 warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
ppigazzini committed Jan 14, 2025
1 parent 84842d1 commit d7f253b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 7 deletions.
6 changes: 3 additions & 3 deletions server/fishtest/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@
==============
APIs hosted on the primary Fishtest instance have read and write access
to the `run_cache` via `rundb.get_run()` and `rundb.buffer()`
to the `run_cache` via `rundb.get_run()` and `rundb.buffer()`
APIs hosted on secondary instances have read access to the `run`
from the database via `rundb.get_run()`. However, they should not
APIs hosted on secondary instances have read access to the `run`
from the database via `rundb.get_run()`. However, they should not
attempt to write to `run_cache` using `rundb.buffer()`.
Proper configuration of `nginx` is crucial for this, and should be done
Expand Down
3 changes: 0 additions & 3 deletions server/fishtest/rundb.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@
Scheduler,
crash_or_time,
estimate_game_duration,
format_results,
get_bad_workers,
get_chi2,
get_hash,
Expand Down Expand Up @@ -935,7 +934,6 @@ def aggregate_unfinished_runs(self, username=None):
if cores > 0:
eta = remaining_hours(run) / cores
pending_hours += eta
results = run["results"]
return (
runs,
pending_hours,
Expand Down Expand Up @@ -1562,7 +1560,6 @@ def stop_run(self, run_id):
run = self.get_run(run_id)
self.set_inactive_run(run)

results = run["results"]
try:
validate(runs_schema, run, "run")
except ValidationError as e:
Expand Down
1 change: 0 additions & 1 deletion server/fishtest/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -1488,7 +1488,6 @@ def tests_view(request):
if run is None:
raise HTTPNotFound()
follow = 1 if "follow" in request.params else 0
results = run["results"]
run_args = [("id", str(run["_id"]), "")]
if run.get("rescheduled_from"):
run_args.append(("rescheduled_from", run["rescheduled_from"], ""))
Expand Down

0 comments on commit d7f253b

Please sign in to comment.