clean up the code

server/fishtest/api.py

@@ -538,7 +538,7 @@ def download_run_pgns(self):
             return Response("Invalid filename format", status=400)
         run_id = match.group(1)
         pgns_reader, total_size = self.request.rundb.get_run_pgns(run_id)
-        if pgns_reader is None or total_size == 0:
+        if pgns_reader is None:
             return Response("No data found", status=404)
         response = Response(content_type="application/gzip")
         response.app_iter = FileIter(pgns_reader)

server/fishtest/rundb.py

@@ -264,27 +264,25 @@ def upload_pgn(self, run_id, pgn_zip):
 
     def get_pgn(self, run_id):
         pgn = self.pgndb.find_one({"run_id": run_id})
-        if pgn:
-            return pgn["pgn_zip"]
-        return None
+        return pgn["pgn_zip"] if pgn else None
 
     def get_run_pgns(self, run_id):
         pgns = self.pgndb.find({"run_id": {"$regex": f"^{run_id}-\\d+"}})
-        if pgns is not None:
-            # Create a generator that yields each pgn.gz file
-            pgn_generator = (pgn["pgn_zip"] for pgn in pgns)
-            # Compute the total size using MongoDB's aggregation framework
-            total_size_agg = self.pgndb.aggregate(
-                [
-                    {"$match": {"run_id": {"$regex": f"^{run_id}-\\d+"}}},
-                    {"$group": {"_id": None, "totalSize": {"$sum": "$size"}}},
-                ]
-            )
-            total_size = (
-                total_size_agg.next()["totalSize"] if total_size_agg.alive else 0
-            )
-            return GeneratorAsFileReader(pgn_generator), total_size
-        return None, 0
+        # Compute the total size using MongoDB's aggregation framework
+        total_size_agg = self.pgndb.aggregate(
+            [
+                {"$match": {"run_id": {"$regex": f"^{run_id}-\\d+"}}},
+                {"$group": {"_id": None, "totalSize": {"$sum": "$size"}}},
+            ]
+        )
+        total_size = total_size_agg.next()["totalSize"] if total_size_agg.alive else 0
+        # Create a generator that yields each pgn.gz file
+        pgn_generator = (
+            GeneratorAsFileReader(pgn["pgn_zip"] for pgn in pgns)
+            if total_size
+            else None
+        )
+        return pgn_generator, total_size
 
     def write_nn(self, net):
         validate(nn_schema, net, "net")