feat: Case hotspots #229
Merged
feat: Case hotspots #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up if the population exists
|
Visit the preview URL for this PR (updated for commit 86d7e0b): https://signal-ri--pr229-case-hotspots-jpncmowe.web.app (expires Tue, 30 Apr 2024 20:21:01 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 00e607c4a7f37e76a51e675795a92e0f2f741992 |
|
I'm going to take a look at fixing up the gap chart ! |
|
@eldu to investigate squishification |
…into case-hotspots
fix: hotspot chart domain
eldu
requested changes
Apr 18, 2024
eldu
approved these changes
Apr 23, 2024
| import { fetchKeys } from "../../../utils/firebase"; | ||
| import { prettyDate } from "../../../utils/utils"; | ||
|
|
||
| // const datasetName = "case_hotspots"; |
There was a problem hiding this comment.
Ooohhhhhhh commented out code
| export const sortByProperty = (property) => (a, b) => { | ||
| let valA = a[property]; | ||
| let valB = b[property]; | ||
|
|
||
| // if NaN, make MIN_VALUE |
There was a problem hiding this comment.
Wondering if it should be 0, but I'm also okay with Number.MIN_VALUE !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.