Test hidden modeless dialog #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppescher
force-pushed
the
test-hidden-modeless-dialog
branch
from
5fd5e0a
to
60e5eb3
Compare
|
Moved this comment to the correct PR. |
|
This fixes the issue for mpc-hc after removal of our custom code. |
|
Nice! I will propagate this change to the other dialog flavors. |
ppescher
force-pushed
the
test-hidden-modeless-dialog
branch
from
60e5eb3
to
33302a8
Compare
ppescher
force-pushed
the
test-hidden-modeless-dialog
branch
from
33302a8
to
a9dec5e
Compare
ppescher
force-pushed
the
test-hidden-modeless-dialog
branch
from
a9dec5e
to
33c6cc3
Compare
|
Any chance of this making it to master soon? I have updated mpc-hc code to take advantage but I would like it to be based on commited code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address save/restore on a modeless dialog initially hidden, that was incorrectly making it visible during initialization.
Now the restore process is postponed until the dialog is made visible for the first time, preventing the override of the initial hidden state.
See pull request #32 for details. Anyone interested please try this patch also in your own use cases, to confirm it does what it's supposed to and there are no unexpected side-effects.