Currency:Updated build-script for onnx #5342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham-dayma-ibm
requested changes
Jan 24, 2025
There was a problem hiding this comment.
@vinodk99 I do see missing pieces while comparing it with open-ce script
Don't see we enabled specific flags while building protobuf. Also we didn't installed abseilcpp(may be used for buidling wheel). Please confirm once.
@nikhil-kalbande
|
@shubham-dayma-ibm addressed review comments |
nikhil-kalbande
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
set -eoption enabled and observe success ?