Add space character in IdWithWildcardsNetworkElementIdentifier regex #3321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CARON Alice <[email protected]>
alicecaron
changed the title
olperr1
requested changes
Feb 12, 2025
.../main/java/com/powsybl/iidm/network/identifiers/IdWithWildcardsNetworkElementIdentifier.java
Outdated
Show resolved
Hide resolved
Signed-off-by: CARON Alice <[email protected]>
alicecaron
force-pushed
the
add-space-in-wild-card
branch
from
67721f6 to
8578bf5
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Add new use case for the existing feature: search for all the
Identifiablematching an id pattern a given network.What is the current behavior?
The pattern to match in order to search for identifiables in a network does not allow the presence of the "space" character.
What is the new behavior (if this is a feature change)?
The pattern to match in order to search for identifiables in a network allows the presence of the "space" character.
Does this PR introduce a breaking change or deprecate an API?
Other information:
Maybe think of other characters that could be useful to include in the possible patterns (for UCTE possibilities compliance for instance).