Cgmes import update. Import EQ and SSH separately. DanglingLines. #3310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]> # Conflicts: # cgmes/cgmes-completion/src/test/java/com/powsybl/cgmes/completion/CgmesCompletionTest.java # cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/Conversion.java # iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/NetworkImpl.java
Signed-off-by: marquesja1 <[email protected]> # Conflicts: # cgmes/cgmes-completion/src/test/java/com/powsybl/cgmes/completion/CgmesCompletionTest.java # cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/Conversion.java # iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/NetworkImpl.java
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]> # Conflicts: # cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/RegulatingControlMappingForGenerators.java # cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/RegulatingControlMappingForStaticVarCompensators.java
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]> # Conflicts: # cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/Context.java # cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/elements/transformers/AbstractTransformerConversion.java # cgmes/cgmes-conversion/src/test/resources/functional-logs/microGridBaseCaseBE-target-deadband.txt # cgmes/cgmes-model/src/main/java/com/powsybl/cgmes/model/AbstractCgmesModel.java # cgmes/cgmes-model/src/main/java/com/powsybl/cgmes/model/CgmesModelFactory.java
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
…nsformers Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]> # Conflicts: # cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/RegulatingControlMappingForStaticVarCompensators.java
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
Signed-off-by: marquesja1 <[email protected]>
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
Signed-off-by: marquesja1 <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
Feature
Does this PR introduce a new Powsybl Action implying to be implemented in simulators or pypowsybl?
What is the current behavior?
EQ and SSH are imported together during the conversion process.
What is the new behavior (if this is a feature change)?
EQ and SSH are imported separately.
The objective is to ultimately import a single EQ file and multiple SSH files.
All the changes will be split in multiple smaller PRs so the implementation will be done in an incremental way.
Current main workflow will be kept for some equipment. We will move them one by one to the new scheme.
This PR contains only the changes for
danglingLines.When performing the update, we traverse all the IIDM danglingLines and for each danglingLine we obtain the SSH data and call a specific update method.
The update method is located in the corresponding convert class and a different update class is defined for each
equipment. The update classes are defined as public static classes.
There are some methods with both implementations:
connect and convertedTerminals for importing EQ + SSH together
connectWithOnlyEq and convertedTerminalsWithOnlyEq for importing EQ + SSH separately
The validation scheme has been modified, initially the validation level is set to EQUIPMENT and only after the update is moved to SSH.
The injection at the boundary node of the danglingLine is obtained from the equivalentInjection.
An alternative from the current version, which calculated the flow at the boundary by accumulating the injection from all the equipment inside the boundary connected to the boundary node, has been removed.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: