-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReportNode i18n #3299
base: main
Are you sure you want to change the base?
ReportNode i18n #3299
Conversation
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
|
It seems more natural to use |
To help for this PR, some scripts are already in development in powsybl/powsybl-dev-tools#121 |
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
Language can hardly be changed
What is the new behavior (if this is a feature change)?
Language can be set by setting
Locale
to root ReportNode.Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
All the message templates should be moved to a ResourceBundle.
Translation into french is expected - please request for help if needed.
withLocaleMessageTemplate(key, bundleBaseName)
should be used instead of deprecatedwithMessageTemplate(key, messageTemplate)