Add backward compatibility for CgmesControlAreas extension deserialization #3298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
rcourtier
approved these changes
Jan 31, 2025
...ensions/src/main/java/com/powsybl/cgmes/extensions/compatibility/CgmesControlAreasSerDe.java
Show resolved
Hide resolved
|
I have tested the backward compatibility using a real world test case and it works perfectly. |
zamarrenolm
approved these changes
Jan 31, 2025
flo-dup
requested changes
Feb 11, 2025
|
|
||
| @Override | ||
| public void write(DummyExt extension, SerializerContext context) { | ||
| throw new UnsupportedOperationException("Backward writing compatibility is not yet supported."); |
There was a problem hiding this comment.
yet means we'll do it one day, will we? Besides shouldn't this rather be something like "cannot happen"? We're here with a DummyExt which is never created, and cannot be created.
...ensions/src/main/java/com/powsybl/cgmes/extensions/compatibility/CgmesControlAreasSerDe.java
Outdated
Show resolved
Hide resolved
flo-dup
approved these changes
Feb 11, 2025
…tension Signed-off-by: Olivier Perrin <[email protected]>
Signed-off-by: Olivier Perrin <[email protected]>
Signed-off-by: Olivier Perrin <[email protected]>
Signed-off-by: Olivier Perrin <[email protected]>
Signed-off-by: Olivier Perrin <[email protected]>
Signed-off-by: Olivier Perrin <[email protected]>
olperr1
force-pushed
the
cgmes_control_areas_compatibility_serde
branch
from
e90f061 to
3e1159d
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
Does this PR introduce a new Powsybl Action implying to be implemented in simulators or pypowsybl?
What is the current behavior?
#3149 removes the
CgmesControlAreasin favor of the usage of IIDMAreas, but the backward compatibility with the extension is not supported. Therefore when importing an old generated IIDM network containing the extension, the content of this extension is not loaded and no CGMES areas are created.What is the new behavior (if this is a feature change)?
With this PR, the serialized extension is read and IIDM
Areas are created for eachCgmesControlAreaof the extension.Note that when reading a CgmesControlArea from the serialized extension, if an
Areawith the same ID is already present on the network, the CgmesControlArea is skipped.Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information:
For now, only the reading compatibility is supported, because it is not trivial to implement the writing compatibility: there's no extension corresponding to the CGMES areas on the network, so the extension serialization mechanism could not be used directly