New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed backdrop removal #54

Open

ihortymoshenko wants to merge 1 commit into powmedia:master from ihortymoshenko:hotfix/backdrop

Contributor

ihortymoshenko commented Dec 20, 2013

Hello!

Bootstrap 3 no longer triggers the click event on the backdrop. This PR fixes the bug.

Thanks!


          Fixed backdrop removal

e2ac106

rejas commented Jul 24, 2014

I'd change the first part (line 89-91) to

            if (!this.$el.is($(event.target)) || !this.options.allowCancel) {
                return;
            }

Otherwise the option "allowCancel:false" could be circumvented by clicking on the backdrop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet