Fix extracting PowerSync library from JAR #174
Merged
+19
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I could not reproduce any crash or error when closing the Supabase demo on Windows. I think windows.1.mp4 |
stevensJourney
previously approved these changes
Apr 24, 2025
stevensJourney
previously approved these changes
Apr 24, 2025
stevensJourney
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a workaround for a Windows-specific issue,
R::class.java.getResource(path)was used to obtain a path tolibpowersync.dylib.While this works during development, it fails for builds we distribute to users because
libpowersync.dylibis inside a JAR, so the path can't bedlopened by SQLite.This reverts the implementation to extract the library into a temporary file again. I couldn't test this on Windows to debug any potentially regressions there (which was the motivation for the change). I'm using
deleteOnCloseinstead of a custom shutdown hook, I'm not sure if that makes a difference?Closes #172