Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A bunch of new features #26

Merged
merged 61 commits into from
Apr 7, 2024
Merged

A bunch of new features #26

merged 61 commits into from
Apr 7, 2024

Conversation

adya
Copy link
Collaborator

@adya adya commented Mar 25, 2024 •
edited
Loading

  • Exclusive Groups
  • Linked Forms
  • Random Count
  • Fractional Chances #29
  • General refactoring that comes along with it 🙂

adya and others added 27 commits March 13, 2024 00:40
@adya
Added parsing of ExclusionGroup.
f7124a1
@adya
Implemented ExclusionGroups logic.
73149be
@adya
Refactored form lookup to reuse the same logic for both form filters …
d616f29 
…and distributables.
@adya
maintenance
d0c60a1
@adya
Finalized Exclusion groups feature.
03cdbe5 
- Fixed compilation errors
- Fixed support for Keywords.
- Extracted form lookup logic to avoid almost identical code blocks.
- Refactored LookupForms to fit in a new type of lookup for Exclusion Groups.
@adya
Fixed first Keyword wasn't preserving relative order.
31edb4f 
Odd bug where first Keyword was always sorted alphabetically by EditorID 😅
@adya
maintenance
db83300
@adya
Reverted no longer needed change.
a8b3dc9
@adya
Replaced term "exclusion group" with "exclusive group".
5a95589 
Yeah, it bothered me too much 🤓
@adya
Merge pull request #19 from powerof3/feature/exclusive-groups
1e407a1 
Exclusive Groups
@adya
Added support for random count value.
1bf640d 
Count can now be specified in form of range, e.g. 5/20 to produce anywhere between 5 and 20 items.
@adya @github-actions
maintenance
1b99281
@adya
Merged IndexOrCount into a single variant.
f944a82
@adya @github-actions
maintenance
e5eaac4
@adya
Removed unnecessary safety checks to keep maximum performance 😊
f80555f
@adya
Merge pull request #20 from powerof3/feature/random-item-count
7a91d0b 
Random Count
@adya
WIP: Refactored distribution code to reuse in linked distribution.
8bb55e5 
Key change is abstracted out distribution of a given set of entries and to not rely on global Distributables.
@adya
Introduced Linked Distribution initial outline.
0065c94
@adya @github-actions
maintenance
933ac13
@adya
Implemented Linked Distribution.
827b34b 
Probably 😁 needs testing, and updating parsing and lookup to work with full entry format.
@adya
Implemented Linked Distribution parsing.
1926498
@adya
Reversed linked items tree that is logged after lookup.
a9840f0
@adya @github-actions
maintenance
52ac89c
@adya
Merge pull request #21 from powerof3/feature/linked-items
489af26 
Linked Items
@adya
Merge branch 'master' into stable
7dd0328
@adya
Updated CommonLibSSE to latest.
fabda7f
@adya @github-actions
maintenance
88e2eba
@adya adya self-assigned this Mar 25, 2024
adya
adya commented Mar 25, 2024
View reviewed changes
SPID/include/ExclusiveGroups.h Outdated Show resolved Hide resolved
SPID/src/Distribute.cpp Outdated Show resolved Hide resolved
adya and others added 19 commits March 30, 2024 02:20
@adya
Added manual counter for processed forms to properly count inferred f…
7747d4b 
…orms.
@adya
Merge pull request #27 from powerof3/feature/22-allow-specifying-form…
a91a1f0 
…-type-in-linkedf

Type inferring for Linked Forms and Linking of DeathItems
@adya
Added support for fractional chances.
f254f84
@adya @github-actions
maintenance
e155778
@adya
Fixed small typo in comment 😊 clean up.
a879a82
@adya
Merge pull request #30 from powerof3/29-fractional-chances
ef8594d 
Fractional Chances
@adya
Improved logging of type errors during parsing and lookup.
7a31302
@adya @github-actions
maintenance
f545690
@adya
Isolated Exclusive Groups feature's code in respective files.
bde29a0 
This bring Exclusive Groups in line with Linked Forms structure, where features are isolated as much as possible to their own header/source.
@adya
Introduced an alias for Path parameter.
d2f9688
@adya
Introduced Scope for linked forms.
bb018e2
@adya @github-actions
maintenance
b2e692c
@adya
Implemented Local scope for linked forms.
f54db3a
@adya @github-actions
maintenance
6ff3eda
@adya
Implemented Global scope for linked forms.
b36708c
@adya @github-actions
maintenance
f16ce03
@adya
Merge pull request #31 from powerof3/23-local-and-global-linked-items
f54e8a5 
Scope for Linked Forms.
@adya
Renamed ExclusiveGroup types to not be confused with Linked Forms.
78f3468
@adya
Implemented a way to overwrite outfits with linked outfits.
cb7e295
@adya adya marked this pull request as ready for review March 31, 2024 20:40
adya added 3 commits April 4, 2024 00:56
@adya
Remove redundant RE::FormTypeToString calls.
6c0adc0 
FormType is automatically overloaded for std::format.
@adya
Removed skin from type inferring. Added missing leveled spell inferring.
830e42a 
Skin wouldn't work because it would always fall into Item category.
@adya
Added also an NPC's baseTemplateForm to list of IDs.
3dbc218
@adya adya merged commit 4881754 into master Apr 7, 2024
1 check passed
@adya adya deleted the stable branch April 7, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adya adya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adya