FIX target for kubernetes #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
As i used powerapi inside a kubernetes cluster, i saw that the path for the pod and container's id do not match what is used by k8s. (which doesn't use dockershim anymore but containerd)
Powerapi use path like
perf_event/kubepods/where it should beperf_event/kubepods.slice/. I did some changes to match this pattern. Furthermore, in order to visualize data with Prometheus and Grafana whithout making changes to the formula, I modified the target-real-name to be like " podID-containerID " which is arbitrary as i use it with PromQL to have a consumption by pod and containers.Changes: