Add Zitadel Strategy and implement PKCE #154
Open
+520
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 25, 2024
|
Thanks, I've pushed two PR's that deals with public client auth, and have rebased this PR. If you don't mind I'll force push to this PR and do a few follow up commits to streamline the flow. |
|
Absolutely, no problem on my side
…On Wed, Dec 25, 2024, at 23:51, Dan Schultzer wrote:
Thanks, I've pushed two PR's that deals with public client auth, and have rebased this PR. If you don't mind I'll force push to this PR and do a few follow up commits to streamline the flow.
—
Reply to this email directly, view it on GitHub <#154 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAM6I4TEPGXIDE6XQYT67D2HMZH5AVCNFSM6AAAAABKYX5NF6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRSGAYTMNJYGA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a strategy for zitadel.
Zitadel reccommends PKCE with no auth method.
I made changes also to OIDC and Oauth2 strategies to implment PKCE with no auth method for all strategies.
I added tests only for zitadel.