Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Minimal ePBS without Max EB and 7002 #2

Open
wants to merge 112 commits into
base: dev
Choose a base branch
from
Open

[WIP] Minimal ePBS without Max EB and 7002 #2

wants to merge 112 commits into from

Commits on Apr 3, 2024

  1. init

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    5ef39b8 View commit details
    Browse the repository at this point in the history

  2. Add engine methods and check IL validity

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    1a49a51 View commit details
    Browse the repository at this point in the history

  3. add small design notes for ILs

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    0e2267d View commit details
    Browse the repository at this point in the history

  4. check for gas usage after payload insertion 

    Also notice that the DA issue only happens if all the transactions are
invalidated in the same slot
    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    844381d View commit details
    Browse the repository at this point in the history

  5. Add helpers that change on ePBS

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    ee37d4c View commit details
    Browse the repository at this point in the history

  6. switch to gas limit instead of usage as pointed by V. Buterin

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    13d75bc View commit details
    Browse the repository at this point in the history

  7. Added more changed helpers 

    Notice that the whole thing is broken by the construct if index < len(validators) else.
    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    f4b566b View commit details
    Browse the repository at this point in the history

  8. change design notes

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    08b881d View commit details
    Browse the repository at this point in the history

  9. minor changes

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    d339dfc View commit details
    Browse the repository at this point in the history

  10. First forkchoice changes. 

    - Added handlers for execution payloads and checks inclusion lists
  availability on consensus blocks
    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    ff1eff7 View commit details
    Browse the repository at this point in the history

  11. don't modify verify_block_signature

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    ef7bd40 View commit details
    Browse the repository at this point in the history

  12. remove clutter

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    9dbd2c5 View commit details
    Browse the repository at this point in the history

  13. Check IL compatibility with parent block hash

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    c7331a1 View commit details
    Browse the repository at this point in the history

  14. Do not broadcast the parent_block_hash but use it as parameter to the EL

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    8d6ce8b View commit details
    Browse the repository at this point in the history

  15. process payment immediately

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    759cdd6 View commit details
    Browse the repository at this point in the history

  16. Deal with withdrawals

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    90b42e6 View commit details
    Browse the repository at this point in the history

  17. fix withdrawals, check only in the CL

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    a604462 View commit details
    Browse the repository at this point in the history

  18. remove unused request dataclass

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    d6ca928 View commit details
    Browse the repository at this point in the history

  19. pass the propsoer_index to process_execution_payload_header

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    70a6e6d View commit details
    Browse the repository at this point in the history

  20. run doctoc

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    2c4fc84 View commit details
    Browse the repository at this point in the history

  21. only cache the withdrawals root in the state

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    43a8dd6 View commit details
    Browse the repository at this point in the history

  22. ptc rewards pass 1

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    52067d5 View commit details
    Browse the repository at this point in the history

  23. only pass relevant IL info to the EL

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    a3c2468 View commit details
    Browse the repository at this point in the history

  24. Use envelopes instead of adding builder info to the payload 

    Move the builder id and other unnecessary information outside of the
payload.
    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    800a910 View commit details
    Browse the repository at this point in the history

  25. ptc message handlers in forkchoice

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    0228ea0 View commit details
    Browse the repository at this point in the history

  26. take ptc members from all committees

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    1ae9cd9 View commit details
    Browse the repository at this point in the history

  27. add forkchoice helper to get committee voted

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    2ed9678 View commit details
    Browse the repository at this point in the history

  28. add rewards and ptc attestations to the design doc

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    4389af4 View commit details
    Browse the repository at this point in the history

  29. doctoc

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    23c46d7 View commit details
    Browse the repository at this point in the history

  30. Design decisions in forkchoice

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    4fe85f8 View commit details
    Browse the repository at this point in the history

  31. checkpoint descriptions

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    4eaddd9 View commit details
    Browse the repository at this point in the history

  32. fix PTC rewards for old blocks

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    d9e0278 View commit details
    Browse the repository at this point in the history

  33. update forkchoice weights, take 1

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    4060a9b View commit details
    Browse the repository at this point in the history

  34. doctoc updated

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    f3006ca View commit details
    Browse the repository at this point in the history

  35. add head_root

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    5004908 View commit details
    Browse the repository at this point in the history

  36. add comment on equivocation

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    dc7b24c View commit details
    Browse the repository at this point in the history

  37. remove signed execution payload header

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    169e02b View commit details
    Browse the repository at this point in the history

  38. typos

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    a7e3ba1 View commit details
    Browse the repository at this point in the history

  39. add max EB changes

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    837897e View commit details
    Browse the repository at this point in the history

  40. add el withdraws in the beacon block body

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    a29a34c View commit details
    Browse the repository at this point in the history

  41. doctoc

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    faacffe View commit details
    Browse the repository at this point in the history

  42. add slot to IL

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    aa88419 View commit details
    Browse the repository at this point in the history

  43. use head_root in get_head

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    66f8ee1 View commit details
    Browse the repository at this point in the history

  44. design notes

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    b06e017 View commit details
    Browse the repository at this point in the history

  45. onboard builders

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    c2eacf9 View commit details
    Browse the repository at this point in the history

  46. block-slot is missing

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    1c6304b View commit details
    Browse the repository at this point in the history

  47. block slot

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    c43400a View commit details
    Browse the repository at this point in the history

  48. typos

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    0c645ad View commit details
    Browse the repository at this point in the history

  49. typos Terence found with chatgpt

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    bcc1d5f View commit details
    Browse the repository at this point in the history

  50. add helper to get payload hash

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    fad1f49 View commit details
    Browse the repository at this point in the history

  51. minimal churn for transfers

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    458bb8f View commit details
    Browse the repository at this point in the history

  52. add mapping for exclusion

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    296a4e8 View commit details
    Browse the repository at this point in the history

  53. Revert "add mapping for exclusion" 

    This reverts commit 874e4c7.
    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    9c5e60b View commit details
    Browse the repository at this point in the history

  54. fix design for exclusion list

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    545d657 View commit details
    Browse the repository at this point in the history

  55. fix signature verification

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    bffcc04 View commit details
    Browse the repository at this point in the history

  56. fix il proposers

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    99b2109 View commit details
    Browse the repository at this point in the history

  57. add censoring description

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    5db1f29 View commit details
    Browse the repository at this point in the history

  58. blockchain.md

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    f8db1ea View commit details
    Browse the repository at this point in the history

  59. doctoc

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    37e892b View commit details
    Browse the repository at this point in the history

  60. init p2p

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    945d8bb View commit details
    Browse the repository at this point in the history

  61. deal with withdrawals in two steps

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    ba51dcc View commit details
    Browse the repository at this point in the history

  62. more p2p

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    6e03e58 View commit details
    Browse the repository at this point in the history

  63. deal with ptc equivocations

    @potuz
    potuz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    d89e527 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. builder init

    @potuz
    potuz committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    7c5b458 View commit details
    Browse the repository at this point in the history

  2. Some hardening 

    - Add slot and parent hash to the IL, slot to harden against replays,
  hash is not signed and is sent for convenience to the builder
- Add last slot with an inclusion list and the previous slot with an IL
  to the beacon state so that it can be enforced that the payload
includes the right inclusion list to be satisfied.
    @potuz
    potuz committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    7198b11 View commit details
    Browse the repository at this point in the history

  3. blob sidecar changes

    @potuz
    potuz committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    7adb9ea View commit details
    Browse the repository at this point in the history

  4. engine init

    @potuz
    potuz committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    4160deb View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. doctoc

    @potuz
    potuz committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    77cd6aa View commit details
    Browse the repository at this point in the history

  2. move hash to the inclusion list envelope

    @potuz
    potuz committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    29a1c4d View commit details
    Browse the repository at this point in the history

  3. use min instead of max for get_ptc

    @potuz
    potuz committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    2bde439 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2024

  1. add parent_block_root to the execution bid

    @potuz
    potuz committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    5759e34 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. beacon block p2p changes

    @potuz
    potuz committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    de20380 View commit details
    Browse the repository at this point in the history

  2. on_block and keep unsigned header in state

    @potuz
    potuz committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    c4aa0cd View commit details
    Browse the repository at this point in the history

  3. changed type in state too

    @potuz
    potuz committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    99132a4 View commit details
    Browse the repository at this point in the history

  4. penalize twice the proposer for including bad ptc

    @potuz
    potuz committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    c9e1834 View commit details
    Browse the repository at this point in the history

  5. inclusion list forkchoice handler

    @potuz
    potuz committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    f785453 View commit details
    Browse the repository at this point in the history

  6. ptc_message forkchoice handler

    @potuz
    potuz committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    075837e View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. only check payload hash if not withheld

    @potuz
    potuz committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    0659a91 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. forkchoice no payload boosts

    @potuz
    potuz committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    4d799b2 View commit details
    Browse the repository at this point in the history

  2. Fix ePBS beacon_chain.md typos

    @terencechain @potuz
    terencechain authored and potuz committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    7b6fa0f View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Add payload boosts

    @potuz
    potuz committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    3411f45 View commit details
    Browse the repository at this point in the history

  2. doctoc

    @potuz
    potuz committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    b33c222 View commit details
    Browse the repository at this point in the history

  3. fix typo withheld -> withhold

    @potuz
    potuz committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    680bcdb View commit details
    Browse the repository at this point in the history

  4. apply boost for attestations from blocks as well

    @potuz
    potuz committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    25dde5e View commit details
    Browse the repository at this point in the history

  5. typo

    @potuz
    potuz committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    9fa6e14 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Fix some forkchoice typos

    @terencechain @potuz
    terencechain authored and potuz committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    960e92d View commit details
    Browse the repository at this point in the history

  2. Update specs/_features/epbs/fork-choice.md 

    Co-authored-by: Potuz <[email protected]>
    @terencechain @potuz
    terencechain and potuz committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    018fa39 View commit details
    Browse the repository at this point in the history

  3. fix get_head to take all children with or without payload from justified

    @potuz
    potuz committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    ac93d02 View commit details
    Browse the repository at this point in the history

  4. do not compute the same child twice

    @potuz
    potuz committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    727a043 View commit details
    Browse the repository at this point in the history

  5. Revert "do not compute the same child twice" 

    This reverts commit 727a043.
    @potuz
    potuz committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    5f97041 View commit details
    Browse the repository at this point in the history

  6. Reapply "do not compute the same child twice" 

    This reverts commit 5f97041.
    @potuz
    potuz committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    84280a7 View commit details
    Browse the repository at this point in the history

  7. only iterate over children with actual payloads

    @potuz
    potuz committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    b68d884 View commit details
    Browse the repository at this point in the history

  8. consider PTC vote untying max weight

    @potuz
    potuz committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    8674517 View commit details
    Browse the repository at this point in the history

  9. Fix boost computation

    @potuz
    potuz committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    b2c6482 View commit details
    Browse the repository at this point in the history

  10. use ChildNode across forkchoice

    @potuz
    potuz committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    17b9e90 View commit details
    Browse the repository at this point in the history

  11. doctoc

    @potuz
    potuz committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    c63b81e View commit details
    Browse the repository at this point in the history

  12. modify get_ancestor to return a ChildNode

    @potuz
    potuz committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    5ff8d54 View commit details
    Browse the repository at this point in the history

  13. typo

    @potuz
    potuz committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    f35cc68 View commit details
    Browse the repository at this point in the history

  14. fix boosts for future slots

    @potuz
    potuz committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    18c31e4 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. remove unnecessary node redefinition

    @potuz
    potuz committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    ba0283c View commit details
    Browse the repository at this point in the history

  2. descend only into right payload except at the justified checkpoint

    @potuz
    potuz committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    9edc282 View commit details
    Browse the repository at this point in the history

  3. update head root in get_head loop

    @potuz
    potuz committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    f3a035a View commit details
    Browse the repository at this point in the history

  4. update get_head to use ChildNodes

    @potuz
    potuz committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    6c60686 View commit details
    Browse the repository at this point in the history

  5. stranded on_block simplifications

    @potuz
    potuz committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    502e98d View commit details
    Browse the repository at this point in the history

  6. did not remove process_withdrawals

    @potuz
    potuz committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    05fbb9a View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Add engine_getInclusionListV1 to engine.md

    @terencechain @potuz
    terencechain authored and potuz committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    1e9406d View commit details
    Browse the repository at this point in the history

  2. coherent naming in engine API

    @potuz
    potuz committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    8883b29 View commit details
    Browse the repository at this point in the history

  3. fix unused constant

    @potuz
    potuz committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    ae35416 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Apply suggestions from Leonardo Arias 

    Left out naming suggestions until a later stage.

Co-authored-by: Leonardo Arias <[email protected]>
Co-authored-by: Ryan Schneider <[email protected]>
    @potuz @come-maiz @ryanschneider
    3 people authored Apr 24, 2024
    Configuration menu
    Copy the full SHA
    eedf7fb View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Move exec payload header position to replace latest payload header

    @terencechain @potuz
    terencechain authored and potuz committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    5ebda89 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. require the target blockroot of a PTC message is valid

    @potuz
    potuz committed May 17, 2024
    Configuration menu
    Copy the full SHA
    2decd43 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Add fork logic for ePBS (#6) 

    * Add fork logic
    @terencechain
    terencechain authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    d0060c0 View commit details
    Browse the repository at this point in the history