Skip to content

Commit

Permalink
Drop support for Node < v18 (#1052)
Browse files Browse the repository at this point in the history
  • Loading branch information
appurva21 authored Sep 25, 2024
1 parent f1eda36 commit e7f04b2
Show file tree
Hide file tree
Showing 5 changed files with 57 additions and 45 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [16, 18]
node-version: [18, 20]
os: [ubuntu-latest, windows-latest]
include:
- coverage: true
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
breaking changes:
- GH-1052 Dropped support for Node < v18
unreleased:
fixed bugs:
- GH-1036 Fixed `uncaughtException` event listener not being removed
Expand Down
76 changes: 38 additions & 38 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,15 +45,15 @@
"lodash": "4.17.21",
"postman-collection": "4.5.0",
"teleport-javascript": "1.0.0",
"uvm": "3.0.0"
"uvm": "4.0.0"
},
"devDependencies": {
"@postman/shipit": "^0.4.0",
"@postman/tough-cookie": "4.1.3-postman.1",
"@stylistic/eslint-plugin-js": "^1.8.0",
"ajv": "6.12.5",
"assert": "2.0.0",
"async": "^3.2.5",
"async": "^3.2.6",
"atob": "2.1.2",
"backbone": "1.6.0",
"browserify": "^16.5.2",
Expand Down Expand Up @@ -82,7 +82,7 @@
"karma-mocha-reporter": "^2.2.5",
"liquid-json": "0.3.1",
"lodash3": "3.10.2",
"mocha": "^10.7.0",
"mocha": "^10.7.3",
"moment": "2.30.1",
"nyc": "^15.1.0",
"packity": "^0.3.5",
Expand All @@ -91,14 +91,14 @@
"shelljs": "^0.8.5",
"sinon": "^18.0.0",
"sinon-chai": "^3.7.0",
"terser": "^5.31.3",
"terser": "^5.33.0",
"tsd-jsdoc": "^2.5.0",
"tv4": "1.3.0",
"uniscope": "2.2.0",
"uniscope": "3.0.0",
"watchify": "^4.0.0",
"xml2js": "0.6.2"
},
"engines": {
"node": ">=16"
"node": ">=18"
}
}
10 changes: 10 additions & 0 deletions test/unit/sandbox-sanity.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,16 @@ describe('sandbox', function () {
// Temporarily added to fix browser tests
!propNames.includes('SharedArrayBuffer') && propNames.push('SharedArrayBuffer');
// Make sure all allowed globals exists
const context = Function('return this;')();
for (const prop of allowedGlobals) {
if (prop === 'undefined' || prop === 'SharedArrayBuffer') {
continue;
}
assert.equal(context[prop] !== undefined, true, 'prop ' + prop + ' does not exist');
}
// make sure both propNames and allowedGlobals are same
assert.equal(JSON.stringify(propNames.sort()), JSON.stringify(allowedGlobals.sort()));
Expand Down

0 comments on commit e7f04b2

Please sign in to comment.