Helm chart improvements including allowing user password to be pulled from K8s secret #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Speissi
changed the title
min_pool_size and server_lifetime configurable
|
Checking out the workflow https://github.com/postgresml/pgcat/blob/main/.github/workflows/generate-chart-readme.yaml Has this ever worked? I don't think there is a README.md for the chart? Also the paths are a bit funky if this is expected to work. For example
|
Speissi
force-pushed
the
chore/chart-user-configs
branch
from
736f709
to
b5436dd
Compare
|
The README hook appears to broken. I have some ideas on how to fix, I will merge this as is and fix the hook later |
pseudomuto
added a commit
to pseudomuto/pgcat
that referenced
this pull request
Oct 10, 2024
Generalizing the secret lookup functionality that was added in postgresml#753 to work for `admin_password`, `auth_query_password`, `server_password`, and really any other one. It works by creating a `pgcat.password` template which expects an object containing values for the `password` and `secret` keys. `password` is a literal value normally supplied via `.Values.xyz` value. `secret` is an object with a key and name property that effectively functions like a _secretKeyRef_. When the literal value is not blank, that is used. Otherwise an attempt is made to lookup to supplied key from the named secret and use that. This is exactly how the current implementation of `user_password` works, which avoids any breaking changes. See the function definition for more details. > Note: it seems like `user_passwordSecret` was added (camelCase name) while all the other ones are _snake_case_. I elected to use snake case for the new values, but left `user_passwordSecret` as is to avoid any breaking changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
min_pool_sizeandsever_lifetimeconfigurable under the user section.Why
server_lifetimegets overwritten by the hardcodedserver_lifetimevalue under the user section, which can cause confusion. So, if it is not explicitly set in thevalues.yaml, it should not be set per user at all, and the global value should be respected.min_pool_sizeshould also be configurable and if not set the default value will be3as per the original version of the chart.server_tls = true.statement_timeouthas default value of 0 and should be explicitly enabled.