ProceduralParts consistent to stock tanks in mass and methane support. #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue hemeac/kiwiTechTree#94 is related. |
|
Appears that SMURFF breaks a bit more with this, than it was broken without on Procparts. |
|
Is that an issue, or can I merge this? |
|
I was struggling to make this work with SMURFF, but only way I managed was to rename the TANK_TYPE_OPTION and rewrite the smurff-like patch. That will probably break crafts, but considering the mass ratio was broken before, probably none was using it. On the upside, the label now fits the UI. Maybe add another patch to rename it back? |
|
I personally don't really know what to do there. I'm going to say it's your call :). Let me know when it's ready and i'll merge it in and it'll be in next version. |
|
With this patch, it is as good as it gets. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LFO is left untouched, but appears to be consistent to stock tanks. MethaOxi was added. MethaOxi and HydroOxi were made consistent with the insulated cryo tanks in both dry mass and cost.