Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support compileSDKVersion to 29, android:requestLegacyExternalStorage for Android 10, change file path for copying odk constraints #174

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Ichchhie
Copy link

  • Changed compileSDKVersion to 29, updated a few dependencies in Mapboxsdk for the same
  • Added android:requestLegacyExternalStorage="true" in Manifest file to for Android 10
  • Changed file path for copying constraints from odk inside Android folder
  • added onRequestPermissionsResult to handle directory creation tasks only after permission provided by the user

@Ichchhie Ichchhie changed the title Hotfix/copy odk constraints Support compileSDKVersion to 29, android:requestLegacyExternalStorage, change file path for copying odk constraints Dec 27, 2021
@Ichchhie Ichchhie changed the title Support compileSDKVersion to 29, android:requestLegacyExternalStorage, change file path for copying odk constraints Support compileSDKVersion to 29, android:requestLegacyExternalStorage for Android 10, change file path for copying odk constraints Dec 27, 2021
@danbjoseph
Copy link
Member

Hi, thanks for this! I'm checking to see if someone from HOT OSM can review this PR (they've been using OMK more recently and I don't have Android app development experience).

@Ichchhie
Copy link
Author

Ichchhie commented Dec 30, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants