Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exclude PET from create universal app #6223

Merged
merged 1 commit into from
Feb 4, 2025
Merged

exclude PET from create universal app #6223

merged 1 commit into from
Feb 4, 2025

Conversation

isabelizimm
Copy link
Contributor

Should fix the issue where the build is mad about PET having one build x64 and arm64, since we create a universal build beforehand

Detected file "Contents/Resources/app/extensions/positron-python/python-env-tools/pet" that's the same in both x64 and arm64 builds and not covered by the x64ArchFiles rule: "*/kerberos.node"

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

E2E Tests 🚀
This PR will run tests tagged with: @:critical

readme  valid tags

@jmcphers jmcphers self-requested a review February 4, 2025 20:03
@jmcphers
Copy link
Collaborator

jmcphers commented Feb 4, 2025

Build passed, this LGTM

@isabelizimm isabelizimm marked this pull request as ready for review February 4, 2025 20:58
@isabelizimm isabelizimm merged commit b7f2f08 into main Feb 4, 2025
8 checks passed
@isabelizimm isabelizimm deleted the pet-build-fix branch February 4, 2025 20:58
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmcphers jmcphers Awaiting requested review from jmcphers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isabelizimm @jmcphers