-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds UI to open Data Explorer files as plaintext #6132
Conversation
E2E Tests 🚀 |
I didn't review the code itself, but the feature works well here for a CSV file There's a bit of a quirk when the the button is disabled -- it still has a hover state that makes it look clickable even though the text is grayed out: I also noticed that this button is visible for the data explorer even when it isn't the headless/DuckDB variety. How hard to you think it would be to hide this button altogether when it isn't applicable? For example, this button would never be usable by a data explorer originating from an R or Python kernel session |
I think it's just because I had the Action Bar enabled, if you run the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Adds UI affordance in Data Explorer toolbar to open as text file. The button is available only when *.[csv/tsv] files are open (and disabled when binary files or runtime variables are displayed).
Addresses #5206
e2e: @:data-explorer
Release Notes
New Features
Bug Fixes
QA Notes
Updated existing Data Explorer e2e tests to ensure button is visible when feature is available, and hidden when not. Also added tests to ensure the correct file is opened in a text editor when action is invoked.