Fix problem where we were over eager with disposing variables instances #5720
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to fix leaks by disposing a variables instance instead of just removing a reference to it. Caused wonky data explorer bug.
QA Notes
Steps to reproduce previously broken behavior
Data_Frame <- mtcars
Data_Frame
in variables and make sure it opensData_Frame
in variables and make sure it opens in original editor, not a new one.