Fix final step of Windows auto-update (#6117)

Add missing arg for inno_updater to replace existing install with updated one
posit-dev · Jan 28, 2025 · 6ca1e8c · 6ca1e8c
1 parent ff251d5
commit 6ca1e8c
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/build/win32/positron.iss b/build/win32/positron.iss
@@ -1519,7 +1519,8 @@ begin
 
       StopTunnelServiceIfNeeded();
 
-      Exec(ExpandConstant('{app}\tools\inno_updater.exe'), ExpandConstant('"{app}\{#ExeBasename}.exe" ' + BoolToStr(LockFileExists())), '', SW_SHOW, ewWaitUntilTerminated, UpdateResultCode);
+      // inno_updater requires 3 arguments (exe of current installation, lock file status, and a string for the log)
+      Exec(ExpandConstant('{app}\tools\inno_updater.exe'), ExpandConstant('"{app}\{#ExeBasename}.exe" ' + BoolToStr(LockFileExists()) + ' "Updating Positron..."'), '', SW_SHOW, ewWaitUntilTerminated, UpdateResultCode);
     end;
 
     if ShouldRestartTunnelService then