Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use deploy-pypi environment #590

Merged
merged 2 commits into from
Jan 27, 2025
Merged

ci: use deploy-pypi environment #590

merged 2 commits into from
Jan 27, 2025

Conversation

machow
Copy link
Collaborator

@machow machow commented Jan 27, 2025

This PR moves our pypi-token into a github environment, so we can require review before a github release pushes to pypi.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.73%. Comparing base (f95fcf0) to head (49fcbd4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #590   +/-   ##
=======================================
  Coverage   90.73%   90.73%           
=======================================
  Files          46       46           
  Lines        5416     5416           
=======================================
  Hits         4914     4914           
  Misses        502      502           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@machow
Copy link
Collaborator Author

machow commented Jan 27, 2025

Seems to be working as expected:

image

@github-actions github-actions bot temporarily deployed to pr-590 January 27, 2025 19:33 Destroyed
@machow machow requested a review from rich-iannone January 27, 2025 19:46
Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@machow
Copy link
Collaborator Author

machow commented Jan 27, 2025

Alright, I declined the release review for deploying to pypi, which works well. We should have everything into place so that...

  • a CODEOWNER review is required to merge to main
  • @machow or @rich-iannone need to review triggered pypi deploys (in workflows)
  • people can be given write access, so they can easily preview PR docs / CI

@machow machow merged commit d71ee99 into main Jan 27, 2025
14 checks passed
@rich-iannone rich-iannone deleted the ci-deploy-environment branch January 27, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants