Fix SCSS compilation (missing addition)

posit-dev · Dec 12, 2023 · e0a0d89 · e0a0d89
1 parent f5b3105
commit e0a0d89
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/great_tables/_scss.py b/great_tables/_scss.py
@@ -92,6 +92,7 @@ def compile_scss(data: GTData, id: Optional[str], compress: bool = True) -> str:
         **font_params,
         "heading_subtitle_padding_top": css_add(scss_params["heading_padding"], -1),
         "heading_subtitle_padding_bottom": css_add(scss_params["heading_padding"], 1),
+        "heading_padding_bottom": css_add(scss_params["heading_padding"], 1),
     }
 
     # Handle table id ----

diff --git a/great_tables/css/gt_styles_default.scss b/great_tables/css/gt_styles_default.scss
@@ -110,7 +110,7 @@ p {
   border-right-color: $column_labels_vlines_color;
   vertical-align: bottom;
   padding-top: $column_labels_padding;
-  padding-bottom: $column_labels_padding + 1;
+  padding-bottom: $heading_padding_bottom;
   padding-left: $column_labels_padding_horizontal;
   padding-right: $column_labels_padding_horizontal;
   overflow-x: hidden;

diff --git a/tests/__snapshots__/test_scss.ambr b/tests/__snapshots__/test_scss.ambr
@@ -119,7 +119,7 @@
     border-right-color: #D3D3D3;
     vertical-align: bottom;
     padding-top: 5px;
-    padding-bottom: 5px + 1;
+    padding-bottom: 5px;
     padding-left: 5px;
     padding-right: 5px;
     overflow-x: hidden;