Add more logging for Help proxy errors #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasilge
commented
Dec 11, 2024
| // Get the headers we need. | ||
| let headers = response.headers().clone(); | ||
| let content_type = headers.get("content-type"); | ||
|
|
||
| // Log. | ||
| log::info!( | ||
| "Proxying URL '{:?}' path '{}' content-type is '{:?}'", | ||
| "Proxying URL {:?} path '{}' content-type is '{:?}'", |
There was a problem hiding this comment.
See how these URLs look in the logs now (too many quotes):
posit-dev/positron#3543 (comment)
lionel-
approved these changes
Dec 12, 2024
crates/ark/src/help_proxy.rs
Outdated
| "Got status {} proxying {:?}: {:?}", | ||
| response.status().clone().to_string(), | ||
| target_url.to_string(), | ||
| response.text().await.unwrap(), |
There was a problem hiding this comment.
Since something is wrong in this code path, can we confidently say that response can be properly decoded? Might be better to condition this on Ok()?
There was a problem hiding this comment.
Agreed about the unwrap() feeling unsafe here since we are in a != reqwest::StatusCode::OK state here
There was a problem hiding this comment.
Thanks, both! Improved in a85e592
DavisVaughan
approved these changes
Dec 12, 2024
crates/ark/src/help_proxy.rs
Outdated
| "Got status {} proxying {:?}: {:?}", | ||
| response.status().clone().to_string(), | ||
| target_url.to_string(), | ||
| response.text().await.unwrap(), |
There was a problem hiding this comment.
Agreed about the unwrap() feeling unsafe here since we are in a != reqwest::StatusCode::OK state here
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses posit-dev/positron#3543 by adding some more logging for us to see more detail in what is going on
This PR moves
return HttpResponse::BadGateway().finish()from where it is now to after some logging we would do anyway, and then also adds logging for the error case (the status code plus just the whole body).