Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parseInGenoSep #322

Merged
merged 5 commits into from
Nov 24, 2024
Merged

Fix parseInGenoSep #322

merged 5 commits into from
Nov 24, 2024

Conversation

nevrome
Copy link
Member

@nevrome nevrome commented Nov 21, 2024

Ui - parseInGenoSep has two bugs (I think): It removes needed file extensions (#321) and it reads PLINK data as GenotypeEigenstrat.

This is not a testament to good quality control... I really think we made a mistake with the way we set up our golden tests without the actual optparse-applicative interface.

Please check thoroughly to make sure we get it right now!

@nevrome nevrome requested a review from stschiff November 21, 2024 21:33
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.29%. Comparing base (682f6ba) to head (f7a139c).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/Poseidon/CLI/OptparseApplicativeParsers.hs 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #322      +/-   ##
==========================================
+ Coverage   59.99%   60.29%   +0.30%     
==========================================
  Files          29       29              
  Lines        4179     4181       +2     
  Branches      481      491      +10     
==========================================
+ Hits         2507     2521      +14     
+ Misses       1191     1169      -22     
- Partials      481      491      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@stschiff stschiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh drat. OK, thanks for fixing. Looks all good! Do you want to merge this maybe into the gzip-writing branch? Then we save one version update? Or merge immediately and update the Version?

@nevrome nevrome merged commit 46b0043 into master Nov 24, 2024
2 checks passed
@nevrome nevrome deleted the stillBrokenInput branch November 24, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants