Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed a lot of unused (?) ToJSON and FromJSON instances #310

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

nevrome
Copy link
Member

@nevrome nevrome commented Oct 22, 2024

Following the discussion in #307 here's a PR that removes a large number of ToJSON and FromJSON instances. Maybe you could finish the job in ServerClient.hs, @stschiff.

If we don't use the instances then I'm all for removing them 🙂!

@stschiff
Copy link
Member

OK, great! I have removed the relevant code from ServerClient.hs and also fixed the tests.

@stschiff
Copy link
Member

stschiff commented Oct 23, 2024

From my point this is good to merge into branch typeMania, where I'll have a final look.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.56%. Comparing base (cc4e4af) to head (52f3e4e).
Report is 5 commits behind head on typeMania.

Additional details and impacted files
@@              Coverage Diff              @@
##           typeMania     #310      +/-   ##
=============================================
+ Coverage      58.09%   59.56%   +1.47%     
=============================================
  Files             29       29              
  Lines           4195     4078     -117     
  Branches         517      484      -33     
=============================================
- Hits            2437     2429       -8     
+ Misses          1241     1165      -76     
+ Partials         517      484      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nevrome nevrome merged commit 9344b99 into typeMania Oct 23, 2024
4 checks passed
@nevrome nevrome deleted the removeAesonInstances branch October 23, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants