Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2023_Salazar_MachuPicchu #21

Merged
merged 16 commits into from
Dec 6, 2024
Merged

Add 2023_Salazar_MachuPicchu #21

merged 16 commits into from
Dec 6, 2024

Conversation

TCLamnidis
Copy link
Member

@TCLamnidis TCLamnidis commented Sep 6, 2024

Adds 2023_Salazar_MachuPicchu

Linked to poseidon-framework/minotaur-recipes#18

New packages added to the minotaur archive are always published in version 1.0.0. This means that any and all changes made to the package during the review process, should only bump the Minor or Patch version of the package.

PR checklist:

  • This package contains a BibTex file.
  • If this package already exists in the community archive:
    • The information from the community archive was used to fill-in empty janno fields.
    • The commands used for the fill-in and any tool versions are kept track of in the README file.
  • Country information is also present in the Country_ISO column.

Once the Pull Request has passed the review process, ensure the pacakge version is bumped once more before publishing with:

trident rectify -d <package_dir> --logText 'Bump version for release' --packageVersionMajor --checksumAll

@TCLamnidis TCLamnidis added the help wanted Extra attention is needed label Oct 8, 2024
@Kavlahkaff Kavlahkaff self-assigned this Oct 17, 2024
@TCLamnidis TCLamnidis added Final review needed This PR needs its final review before going live and removed help wanted Extra attention is needed labels Nov 28, 2024
Copy link
Member

@stschiff stschiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. As in the other case: I would remove the empty Janno-columns, but no strong feeling towards that. I may not understand the version policy completely, I would usually include the final version into the very PR for it, but that can also happening after merging, of course.

@TCLamnidis
Copy link
Member Author

the version bump happens after the green light has been given to merge, to ensure the published package is ALWAYS 1.0.0, and includes all changes suggested for the janno

@TCLamnidis TCLamnidis merged commit 38efa93 into main Dec 6, 2024
1 check passed
@TCLamnidis TCLamnidis deleted the 2023_Salazar_MachuPicchu branch December 6, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Final review needed This PR needs its final review before going live
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants