-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2023_Salazar_MachuPicchu #21
Conversation
…g from , to . decimals
This does not belong here
Co-authored-by: Thiseas C. Lamnidis <[email protected]>
filled out .janno
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. As in the other case: I would remove the empty Janno-columns, but no strong feeling towards that. I may not understand the version policy completely, I would usually include the final version into the very PR for it, but that can also happening after merging, of course.
the version bump happens after the green light has been given to merge, to ensure the published package is ALWAYS 1.0.0, and includes all changes suggested for the janno |
Adds
2023_Salazar_MachuPicchu
Linked to poseidon-framework/minotaur-recipes#18
New packages added to the minotaur archive are always published in version
1.0.0
. This means that any and all changes made to the package during the review process, should only bump theMinor
orPatch
version of the package.PR checklist:
Country
information is also present in theCountry_ISO
column.Once the Pull Request has passed the review process, ensure the pacakge version is bumped once more before publishing with: