px_fuse ioctl to abort ios #156
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabirpaul
reviewed
Sep 30, 2020
pxd.h
Outdated
| @@ -28,6 +28,7 @@ | |||
| #define PXD_IOC_DUMP_FC_INFO _IO(PXD_IOCTL_MAGIC, 1) /* 0x505801 */ | |||
| #define PXD_IOC_GET_VERSION _IO(PXD_IOCTL_MAGIC, 2) /* 0x505802 */ | |||
| #define PXD_IOC_INIT _IO(PXD_IOCTL_MAGIC, 3) /* 0x505803 */ | |||
| #define PXD_IOC_ABORT_IOS _IO(PXD_IOCTL_MAGIC, 4) /* 0x505804 */ | |||
There was a problem hiding this comment.
Can u set this number based on master, so it's compatible with the newer list of ioctls.
There was a problem hiding this comment.
ok, will change this
| @@ -1079,6 +1079,15 @@ __acquires(fc->lock) | |||
| end_requests(fc, &fc->processing); | |||
| } | |||
|
|
|||
| void fuse_abort_all_ios(struct fuse_conn *fc) | |||
| { | |||
| printk(KERN_INFO "PXD_IOCTL : Aborting all requests..."); | |||
There was a problem hiding this comment.
Given the context and usage of this function, it should be in pxd.c alongside pxd_abort_context()?
There was a problem hiding this comment.
end_queued_requests function is static and defined in dev.c, so I had to create another function in the same file to export it.
in v2.5.0, we have pxd_timeout(), which calls fuse_abort_conn() in dev.c, that in turn calls end_queued_requests()
I will leave this as is.
prabirpaul
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new ioctl to abort all iOS
Note: this should be used as a last resort to avoid node restart when px is stuck