-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.8.0 #260
Open
vsundarraj-px
wants to merge
8
commits into
master
Choose a base branch
from
2.8.0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
2.8.0 #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Share Cluster : Share Cluster to users and groups Unshare Cluster: Revoke Shared Clusters from users and groups Signed-off-by: Pallav <[email protected]>
Signed-off-by: vsundarraj-px <[email protected]>
…re (#252) Signed-off-by: vsundarraj-px <[email protected]>
metric endpoint exposed to relay logs back to px-backup main pod proto changes PB-6665 | review changes added PB-6665: vendor vendor with 2.8.0 branch
staticcheck is set to v0.4.7 from latest, since 4.7+ requires go version 1.22+. This 4.7 version is also used in px-backup.
…and total time taken for backup and restore operations Signed-off-by: kgarg-px <[email protected]>
vsundarraj-px
requested review from
prashanthpx,
siva-portworx,
vikasit12,
t-nidhin and
dbinnal-px
September 2, 2024 10:23
OSS Scan Results:
Total issues: 43 |
License Evaluation Results:
Total License Issues: 0 |
dbinnal-px
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pallav-px
approved these changes
Sep 3, 2024
t-nidhin
approved these changes
Sep 3, 2024
Signed-off-by: Vikas Kumar <[email protected]> (cherry picked from commit c8437dd)
OSS Scan Results:
Total issues: 43 |
License Evaluation Results:
Total License Issues: 0 |
OSS Scan Results:
Total issues: 46 |
License Evaluation Results:
Total License Issues: 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Merge PR for synching 2.8.0 to master
Which issue(s) this PR fixes (optional)
Closes #
None
Special notes for your reviewer: