Fix progress indicator in offline video processing #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the progress indicator immediately jumps to 100% (see issue #30).
There seem to be multiple methods in the
imageio
library to get the number of frames:len(reader)
reader.get_length()
reader.frame_count()
len(reader)
andreader.get_length()
should technically be the same but give different outputs.reader.get_length()
returnsinf
for a stream, whilelen(reader)
returnssys.maxsize()
.reader.frame_count()
relies onffmpeg
to extract the number of frames.reader.frame_count()
does not seem completely accurate, as I had videos stop at 96% progress, but it seems to be the closest estimate of the 3 methods and is an improvement to the current behaviour.