-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defines files of resolved configuration as inputs #14
Conversation
That makes it possible to skip execution if no duplicates were found and the configurations did not change.
Hey, I really like your plugin and it helps us a lot. I'd like to contribute a change: For us, it would be great, if the task would define inputs and outputs in order to be able to skip the task, if nothing changed in the files to check. For us, the check takes about 10s if nothing is found an about 30s on failure. We would like to trigger the task in every build but it should only perform the real work if something in the dependencies changed. I hope my pull request is going to be accepted. If you like me to change something please contact me! Thank you for your plugin! Greetings, |
Hi will look tonight. Thanks so much for the help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you write tests?
You are right, I should have provided some tests. I am going to write some tests. |
I added some tests illustrating the expected behaviour. Greetings, Heiko |
Is there anything else I can do? |
looking |
Use java 15 Add a couple of assertions
See if this does it https://plugins.gradle.org/plugin/com.portingle.classpath-hell |
Thank you! |
That makes it possible to skip execution if no duplicates were found and the configurations did not change.