Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defines files of resolved configuration as inputs #14

Merged
merged 7 commits into from
Mar 5, 2024

Conversation

webwart-bln
Copy link

That makes it possible to skip execution if no duplicates were found and the configurations did not change.

That makes it possible to skip execution if no duplicates were found and the configurations did not change.
@webwart-bln
Copy link
Author

Hey,

I really like your plugin and it helps us a lot. I'd like to contribute a change: For us, it would be great, if the task would define inputs and outputs in order to be able to skip the task, if nothing changed in the files to check.

For us, the check takes about 10s if nothing is found an about 30s on failure. We would like to trigger the task in every build but it should only perform the real work if something in the dependencies changed.

I hope my pull request is going to be accepted. If you like me to change something please contact me!

Thank you for your plugin!

Greetings,
Heiko

@Johnlon
Copy link
Member

Johnlon commented Feb 22, 2024

Hi will look tonight. Thanks so much for the help

Copy link
Member

@Johnlon Johnlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you write tests?

@webwart-bln
Copy link
Author

You are right, I should have provided some tests. I am going to write some tests.

@webwart-bln
Copy link
Author

I added some tests illustrating the expected behaviour.

Greetings, Heiko

@webwart-bln
Copy link
Author

Is there anything else I can do?

@Johnlon
Copy link
Member

Johnlon commented Mar 5, 2024

looking

@Johnlon Johnlon merged commit fe68d42 into portingle:master Mar 5, 2024
1 check failed
@Johnlon
Copy link
Member

Johnlon commented Mar 5, 2024

See if this does it https://plugins.gradle.org/plugin/com.portingle.classpath-hell
Released 1.10

@webwart-bln
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants