Upgrade Redis, use RESP3 for pubsub #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephank
force-pushed
the
feat/resp3
branch
2 times, most recently
from
72ba033 to
780b6a6
Compare
|
Tried using ConnectionManager instead of MultiplexedConnection, but the way it does reconnects is a little opaque. There appears to be no logging or events to catch at all. Only Sticking with MultiplexedConnection keeps behavior as it previously was: we crash if redis disappears. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finally upgrades the
rediscrate and relies on its support for pubsub, instead of our own solution. We do now require RESP3, which means Redis >= 6.0 (or valkey), which is more than 4 years old by now.