Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

271 flexiblespecific date entry in sender flow #272

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mAkeddar
Copy link
Contributor

Switch button to choose between range and specific date

@mAkeddar mAkeddar linked an issue Sep 18, 2023 that may be closed by this pull request
@mAkeddar mAkeddar temporarily deployed to dev September 18, 2023 12:11 — with GitHub Actions Inactive
@reviewpad
Copy link

reviewpad bot commented Sep 18, 2023

AI-Generated Summary: This pull request introduces a number of improvements in the project. These include:

  • Adding a switch for flexibility in the form. This leads to clean up and reformatting of CSS files to incorporate the new feature. This change is mostly in the CSS for forms.
  • In the enterDrivingTime.tsx file, some import statements have been removed, though their effects are not clear without seeing the rest of the code.
  • The file EnterRequestTime.tsx has undergone several changes, with noticeable ones including renaming it from EnterTime, a switch has been added to toggle the display of a DatePicker and the handling of changing dates, where they are now dispatched to redux.
  • The translation files for English, French and German have been updated to include translations related to the new features added.

Lastly, some improvements were made to Redux in the patch 'some fixes to redux'. The handleChangeDate function now dispatches 'setObjectDateRange' action to the Redux store.

Overall, the changes aim to bring improved flexibility and functionality to the forms.

@github-actions
Copy link

github-actions bot commented Sep 18, 2023

Visit the preview URL for this PR (updated for commit 4b16097):

https://portatodev--pr272-271-flexiblespecific-5eqzr65a.web.app

(expires Sat, 30 Sep 2023 08:53:38 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1ad69377d0acebce2cf10d7d9603fe0f03acd164

@mAkeddar mAkeddar temporarily deployed to dev September 23, 2023 08:50 — with GitHub Actions Inactive
@reviewpad
Copy link

reviewpad bot commented Sep 23, 2023

AI-Generated Summary: This pull request brings changes to several files for improving functionality and user experience. Firstly, it introduces small updates to the Forms.css file, including spacing improvements and adding a switch container. Secondly, it removes redundant imports from the enterDrivingTime.tsx file.

The EnterRequestTime.tsx file receives a significant refactor, incorporating a Switch for flexible vs. specific date input, providing better customization for the user. Depending on the switch position, the form offers either a RangePicker or a DatePicker.

Translated labels for these dates are updated accordingly in the translation.json files for English, French and German.

The second patch includes an enhancement with Redux to handle date selection from the DatePicker - capturing the selected day, transforming it into the 'dd-mm-yyyy' format, and dispatching it with the setObjectDateRange Redux action.

The third patch contains a tweak that authorizes a selection of one specific date as both the start and end date in a date range. Also, a default value handler has been added to the DatePicker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flexible/Specific date entry in sender flow
1 participant