-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add EH-expansion-evaluator tool as a docker image #96
base: main
Are you sure you want to change the base?
Conversation
Let me know if there's a better way to do this, this is my first time making a Docker image out of something that's not a binary on Git. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cd
you've included here will only change the CWD during the build process - to make this permanent (i.e. each time you run the Docker image) you need to use the WORKDIR
keyword
Co-authored-by: Matt Welland <[email protected]>
@@ -0,0 +1,17 @@ | |||
FROM ubuntu:20.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty old by now.
FROM ubuntu:20.04 | |
FROM ubuntu:22.04 |
Co-authored-by: John Marshall <[email protected]>
Co-authored-by: John Marshall <[email protected]>
Co-authored-by: Matt Welland <[email protected]>
Co-authored-by: Matt Welland <[email protected]>
linting errors are going a bit crazy, checking other files in the repo. But I think I've fixed the necessary linting changes. |
Co-authored-by: Matt Welland <[email protected]>
No description provided.