Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add EH-expansion-evaluator tool as a docker image #96

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

hopedisastro
Copy link
Contributor

No description provided.

@hopedisastro
Copy link
Contributor Author

Let me know if there's a better way to do this, this is my first time making a Docker image out of something that's not a binary on Git.

Copy link
Contributor

@MattWellie MattWellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cd you've included here will only change the CWD during the build process - to make this permanent (i.e. each time you run the Docker image) you need to use the WORKDIR keyword

@@ -0,0 +1,17 @@
FROM ubuntu:20.04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty old by now.

Suggested change
FROM ubuntu:20.04
FROM ubuntu:22.04

images/eh-expansion-evaluator/Dockerfile Outdated Show resolved Hide resolved
images/eh-expansion-evaluator/Dockerfile Outdated Show resolved Hide resolved
images/eh-expansion-evaluator/Dockerfile Outdated Show resolved Hide resolved
images/eh-expansion-evaluator/Dockerfile Outdated Show resolved Hide resolved
@hopedisastro
Copy link
Contributor Author

linting errors are going a bit crazy, checking other files in the repo. But I think I've fixed the necessary linting changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants