Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in adding mutations to the recapitated portion of the tree sequence #1496

Open
mufernando opened this issue Jun 22, 2023 · 4 comments
Open
Assignees
Milestone

Comments

@mufernando
Copy link
Member

We will have a similar issue that pyslim had to deal with because of the time in the metadata from SLiM tree sequences.

start_time = metadata["SLiM"]["tick"]

See tskit-dev/pyslim#308 (comment) and tskit-dev/pyslim#311 for the fix

@nspope
Copy link
Collaborator

nspope commented Jun 22, 2023

Gosh, thanks for noticing-- in this case, it's affecting the mutations and not the genealogies, right?

@mufernando
Copy link
Member Author

I don't think it does and @petrelharp agrees. He found this bug btw!

@petrelharp
Copy link
Contributor

And hence very minor - it just results in no mutations for 1 or 2 generations, I think.

@andrewkern
Copy link
Member

@mufernando or @petrelharp will one of you submit a patch?

@petrelharp petrelharp added this to the Version 0.2.1 milestone Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants