Forward SIGTERM and SIGINT in wrapper script #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure that if the wrapper bash script receives a SIGTERM or SIGINT, that is forwarded to the actual player to terminate it. Then, the wrapper script does not terminate itself until the player does, allowing cleanup to happen as normal. This is helpful when running omxplayer from a script that wants to terminate the player. It can just terminate the (wrapper) process that it spawned, which will terminate the script and the player, while still doing proper cleanup. Note that SIGKILL cannot be handled in this way, since that kills the script instantly with no way to trap it.
|
With this PR, I cannot control omxplayer via the keyboard, either natively or via ssh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that if the wrapper bash script receives a SIGTERM or
SIGINT, that is forwarded to the actual player to terminate it. Then,
the wrapper script does not terminate itself until the player does,
allowing cleanup to happen as normal.
This is helpful when running omxplayer from a script that wants to
terminate the player. It can just terminate the (wrapper) process that
it spawned, which will terminate the script and the player, while still
doing proper cleanup.
Note that SIGKILL cannot be handled in this way, since that kills the
script instantly with no way to trap it.
I've tested this change on Raspbian Buster, running omxplayer f543a0d (porting over just the wrapper script from this git repo).