DBus Get Rate returns not the current rate after a DBUS Set Rate. #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As found by Will Price in his python-omxplayer-wrapper
set_rateintegration test #109When setting the Rate through DBus Set Property, the Rate returned by the DBus Get Property doesn't reflect the Rate set.
OMXControl calls the clock OMXSetSpeed with pause_resume argument set to true. This value however doesn't set the (clock internal) variable m_omx_speed. The value of this variable is returned (through OMXPlaySpeed) by the Get Property.
The solution uses the same construction as omxplayer.cpp::SetSpeed to set the clock speed: first call to update the m_omx_speed and a second call to actually set the speed.
Expanded dbuscontrol.sh for Rate Get and Set Property testing:
dbuscontrol.sh rategets the current rate value, anddbuscontrol.sh rate VALUEsets the current rate to VALUE. VALUE is a double datatype value e.g. 1.125.