Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shortcuts): improve key binding validity checks #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Triton171
Copy link

As far as I can tell, both these functions are only used by cosmic-settings which i tested without finding any new issues. If there's anything else I should test, let me know.

I also noticed that in cosmic-settings, the code that focuses any existing invalid keybinding when adding a new one calls Binding::from_str without then checking Binding::is_set for the parsed binding. This should probably also be replaced by Binding::from_str(&shortcut.input).map_or(false, |b| b.is_set()), unless I'm missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard > Shortcuts > System > Open the launcher should render default binding "Super"
1 participant