-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
input: Rework PointerFocus to operate directly on WlSurface #380
Conversation
Seems good. I'm inclined to agree that consolidating things under a single We can still make the keyboard target code less redundant with Smithay/smithay#1334. Then adding a variant or a new trait isn't too painful. |
f2fe363
to
572073b
Compare
SSDs still don't handle touch events, but it looks like that's expected. That can be added later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes all seem reasonable, and everything that I've tested is working fine.
Yeah, that requires implementing the TouchTarget for them and properly supporting TouchGrabs. Left that out for now, as I don't have a touchscreen to test that anyway. |
Continuation of #322 to eventually bump smithay again.
This takes about half of @ids1024 original approach, by leaving the
KeyboardFocusTarget
as is and adjusting thePointerFocusTarget
to go all the way and split upCosmicMapped
focus into iced-UI and surfaces.Reasoning:
WlSurface
variant is a good idea, as we are loosing context. The old PR spent quite a bit of code to reconstruct toplevel-surfaces. Let's simply not do that.CosmicWindow
and especially inCosmicStack
to make the window unaware of the decorations and provide proper wl_poiinter events. All of this is brittle and in some parts even straight up buggy (for admittedly rare input combinations). Lets split the focus in the actual window surface(s) and the decorations to fix this.Remaining TODOs:
element_under
#341