Skip to content

Time applet localization v2 #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 25, 2024
Merged

Conversation

wiiznokes
Copy link
Contributor

fix #401

previous pr: #429
implement this opened pr: #426

New feature:

  • show seconds
  • show day name

This PR now use the https://docs.rs/icu/latest/icu/ crate, which is likely to become a standard in the rust ecosystem, as fluent plan to use it.

Capture d’écran du 2024-05-24 00-41-40
Capture d’écran du 2024-05-24 01-15-29

Know bugs:

  • No horizontal bar for vertical layout (i tried but i'm not sure how to proprely implement it anyway)
  • The AM is not splited somehow (see seconds screenshot). And splitting it like this is smelly

Design

screenshot-2024-05-23-19-02-43
https://www.figma.com/design/4USmAaMoDyYYPzfxlhXV0M/Dock-%26-Top-Panel?node-id=5636-41594&t=Fj9S4W095t4lNWsW-0

Some things to consider

  • It might be better to make a Tick every second even when we don't show seconds, because users would expect their clock to be somehow reactive a bit.
  • icu hourcycle is more exhaustive than the military time boolean
  • maybe it's me but compilation time seems to have increase a bit since icu was added, but i have a low end pc so idk

@wiiznokes
Copy link
Contributor Author

Oh and tracing don't work for me also.

@wiiznokes
Copy link
Contributor Author

We apparently don't need to translate the weekdays: unicode-org/icu4x#4937

@wash2
Copy link
Contributor

wash2 commented May 24, 2024

Thanks, this looks mostly good. I've made a few suggestions which fix the issues you were having with the vertical layout.

@wiiznokes wiiznokes requested a review from wash2 May 24, 2024 15:55
Copy link
Contributor

@wash2 wash2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

I commited it without noticed it
@wiiznokes
Copy link
Contributor Author

Last commit remove the custom makefile i made for debuging

Should be the last commit. It is probably more descriptive
@wash2 wash2 merged commit 406cab9 into pop-os:master May 25, 2024
10 checks passed
@wiiznokes wiiznokes deleted the time-localization-v2 branch May 25, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Time applet] No translation for days and months
2 participants