-
Notifications
You must be signed in to change notification settings - Fork 112
Time applet localization v2 #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Oh and tracing don't work for me also. |
We apparently don't need to translate the weekdays: unicode-org/icu4x#4937 |
Thanks, this looks mostly good. I've made a few suggestions which fix the issues you were having with the vertical layout. |
Co-authored-by: Ashley Wulber <[email protected]>
Co-authored-by: Ashley Wulber <[email protected]>
Co-authored-by: Ashley Wulber <[email protected]>
Co-authored-by: Ashley Wulber <[email protected]>
Co-authored-by: Ashley Wulber <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
Last commit remove the custom makefile i made for debuging |
Should be the last commit. It is probably more descriptive
fix #401
previous pr: #429
implement this opened pr: #426
New feature:
This PR now use the https://docs.rs/icu/latest/icu/ crate, which is likely to become a standard in the rust ecosystem, as fluent plan to use it.
Know bugs:
Design
https://www.figma.com/design/4USmAaMoDyYYPzfxlhXV0M/Dock-%26-Top-Panel?node-id=5636-41594&t=Fj9S4W095t4lNWsW-0
Some things to consider